vcpkg exit code(compilation) #1

New Issue

autarch · 2023-12-12T20:59:14+02:00

autarch commented

2023-12-12 20:59:14 +02:00

I never saw that error, not sure whats the cause.
i did git fetch and about vcpkg exit code, idk

![image](/attachments/ea9b02c0-d88c-4905-889c-4ddb12da0228) I never saw that error, not sure whats the cause. i did git fetch and about vcpkg exit code, idk

image.png

36 KiB

autarch commented

2023-12-12 20:59:47 +02:00

all libs installed via vcpkg :x86-windows-static

autarch changed title from ~~exit code(compilation)~~ to vcpkg exit code(compilation)

2023-12-12 21:06:06 +02:00

Exynox commented

2023-12-13 22:57:42 +02:00

Hi,
This looks like a vcpkg issue. Try reinstalling vcpkg and see what happens. Also, this project uses vcpkg in manifest mode, so it should (and tries here) to install dependencies automatically.

I might try compiling on a fresh install of VS in the near future as to write a small guide on compiling.

Hi, This looks like a vcpkg issue. Try reinstalling vcpkg and see what happens. Also, this project uses vcpkg in manifest mode, so it should (and tries here) to install dependencies automatically. I might try compiling on a fresh install of VS in the near future as to write a small guide on compiling.

❤️ 1

eXploit commented

2024-01-27 20:30:23 +02:00

There is a related issue in the way vcpkg manifest is setup.
Currently on the "UserInterface" is using the manifest, but some other pojects also need the "lzo" dependency.

VisualStudio will first attempt to build all "UserInterface" dependencies first (the projects inside the solution) and only then will proceed to install vcpkg's dependencies. This will cause the projects like EterLib or EterBase to fail because vcpkg didn't install "lzo", then if this fails VS will not continue with the installation of vcpkg dependencies.

Hope i made myself clear.

@Exynox I have a local branch that set's the vcpkg manifest mode for all projects in order to solve this issue, although it looks like i don't have permissions to push the branch nor to open a PR.

There is a related issue in the way vcpkg manifest is setup. Currently on the "UserInterface" is using the manifest, but some other pojects also need the "lzo" dependency. VisualStudio will first attempt to build all "UserInterface" dependencies first (the projects inside the solution) and only then will proceed to install vcpkg's dependencies. This will cause the projects like EterLib or EterBase to fail because vcpkg didn't install "lzo", then if this fails VS will not continue with the installation of vcpkg dependencies. Hope i made myself clear. @Exynox I have a local branch that set's the vcpkg manifest mode for all projects in order to solve this issue, although it looks like i don't have permissions to push the branch nor to open a PR.

Exynox commented

2024-01-28 10:47:02 +02:00

@eXploit That sounds really weird. Have you tried forking this project to your own namespace, pushing the local branch to that, and then try to create a PR? That's "The Git way"™ of doing things and it should work. Otherwise, I think I can give you Collaborator permissions.

(sorry for the mess, I am coming from GitLab and it works a bit different)

@eXploit That sounds really weird. Have you tried forking this project to your own namespace, pushing the local branch to that, and then try to create a PR? That's "The Git way"™ of doing things and it should work. Otherwise, I think I can give you Collaborator permissions. (sorry for the mess, I am coming from GitLab and it works a bit different)

eXploit referenced this issue

2024-02-09 00:20:17 +02:00

Set vcpkg manifest to be used within all projects #2

eXploit commented

2024-02-09 00:25:39 +02:00

@Exynox Nevermind, i was just being dumb. I am not used to collaborate in public repositories.
Sorry for the delay, nonetheless this PR should solve the issue: #2

@Exynox Nevermind, i was just being dumb. I am not used to collaborate in public repositories. Sorry for the delay, nonetheless this PR should solve the issue: https://git.old-metin2.com/metin2/client/pulls/2

Exynox commented

2024-02-10 20:10:58 +02:00

Merged! Thank you! I've sent you an e-mail with a discord invite!

Exynox closed this issue

2024-02-10 20:10:58 +02:00

Sign in to join this conversation.