vcpkg exit code(compilation) #1
Labels
No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: metin2/client#1
Loading…
Reference in New Issue
Block a user
No description provided.
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
I never saw that error, not sure whats the cause.
i did git fetch and about vcpkg exit code, idk
all libs installed via vcpkg :x86-windows-static
exit code(compilation)to vcpkg exit code(compilation)Hi,
This looks like a vcpkg issue. Try reinstalling vcpkg and see what happens. Also, this project uses vcpkg in manifest mode, so it should (and tries here) to install dependencies automatically.
I might try compiling on a fresh install of VS in the near future as to write a small guide on compiling.
There is a related issue in the way vcpkg manifest is setup.
Currently on the "UserInterface" is using the manifest, but some other pojects also need the "lzo" dependency.
VisualStudio will first attempt to build all "UserInterface" dependencies first (the projects inside the solution) and only then will proceed to install vcpkg's dependencies. This will cause the projects like EterLib or EterBase to fail because vcpkg didn't install "lzo", then if this fails VS will not continue with the installation of vcpkg dependencies.
Hope i made myself clear.
@Exynox I have a local branch that set's the vcpkg manifest mode for all projects in order to solve this issue, although it looks like i don't have permissions to push the branch nor to open a PR.
@eXploit That sounds really weird. Have you tried forking this project to your own namespace, pushing the local branch to that, and then try to create a PR? That's "The Git way"™ of doing things and it should work. Otherwise, I think I can give you Collaborator permissions.
(sorry for the mess, I am coming from GitLab and it works a bit different)
@Exynox Nevermind, i was just being dumb. I am not used to collaborate in public repositories.
Sorry for the delay, nonetheless this PR should solve the issue: #2
Merged! Thank you! I've sent you an e-mail with a discord invite!