metin2/server
4
3
Fork 13
Code Issues 13 Pull Requests 3 Packages Projects Releases Wiki Activity

Improve packet reading memory safety #4

New Issue
Open
opened 2023-12-29 22:17:42 +02:00 by Exynox · 0 comments
Exynox commented 2023-12-29 22:17:42 +02:00
Owner
Copy Link

Currently, most network input functions operate on the buffer pointer to read additional data if necessary:

image

This behaviour is unsafe, as it might cause buffer overruns for malformed packets, and should be replaced with some kind of wrapper object that should check the buffer bounds.

Currently, most network input functions operate on the buffer pointer to read additional data if necessary: ![image](/attachments/e7c73822-8699-4b08-8d18-cbd5dff03929) This behaviour is unsafe, as it might cause buffer overruns for malformed packets, and should be replaced with some kind of wrapper object that should check the buffer bounds.
image.png
20 KiB
Exynox added the
enhancement
 label 2023-12-29 22:17:42 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
bug
Something is not working
duplicate
This issue or pull request already exists
enhancement
New feature
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
wontfix
This won't be fixed
No Label
enhancement
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
Exynox
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: metin2/server#4
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?