metin2/server
metin2
/
server
2
2
Fork 9
Code Issues 15 Pull Requests 2 Packages Projects Releases Wiki Activity

Improve packet reading memory safety #4

New Issue
Open
opened 2023-12-29 22:17:42 +02:00 by Exynox · 0 comments
Exynox commented 2023-12-29 22:17:42 +02:00
Owner
Copy Link

Currently, most network input functions operate on the buffer pointer to read additional data if necessary:

image

This behaviour is unsafe, as it might cause buffer overruns for malformed packets, and should be replaced with some kind of wrapper object that should check the buffer bounds.

Currently, most network input functions operate on the buffer pointer to read additional data if necessary: ![image](/attachments/e7c73822-8699-4b08-8d18-cbd5dff03929) This behaviour is unsafe, as it might cause buffer overruns for malformed packets, and should be replaced with some kind of wrapper object that should check the buffer bounds.
image.png
20 KiB
Exynox added the
enhancement
 label 2023-12-29 22:17:42 +02:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
nightly
0.2.2
0.2.1
0.2.0
0.1.1
0.1.0
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: metin2/server#4
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?