metin2/server
metin2/server
2
2
Fork 10
Code Issues 12 Pull Requests 3 Packages Projects Releases Wiki Activity

Default all localized behavior to European logic #22

Merged
Exynox merged 20 commits from Tr0n/server:localization/default-gf-eu into nightly 2024-04-09 21:47:23 +03:00
Conversation 4 Commits 20 Files Changed 58 +4 -15
1 changed files with 4 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ba44269071 - Show all commits

19
src/game/src/char_skill.cpp
View File

@ -378,12 +378,6 @@ bool CHARACTER::LearnGrandMasterSkill(DWORD dwSkillVnum)
}
// END_OF_ADD_GRANDMASTER_SKILL
static bool FN_should_check_exp(LPCHARACTER ch)
{
return true;
}
bool CHARACTER::LearnSkillByBook(DWORD dwSkillVnum, BYTE bProb)
Tr0n marked this conversation as resolved
Exynox commented 2024-04-08 21:51:11 +03:00
Review
Copy Link

Function always returns true, therefore it can be removed.

Function always returns true, therefore it can be removed.
Tr0n commented 2024-04-09 18:13:35 +03:00
Review
Copy Link

I will remove it entirely. Thought it would be good to still have the provision to implement own logic.
But you're right coding for what you "might do" in the future is not good.

I will remove it entirely. Thought it would be good to still have the provision to implement own logic. But you're right coding for what you "might do" in the future is not good.
👍 1
{
const CSkillProto* pkSk = CSkillManager::instance().Get(dwSkillVnum);
@ -397,17 +391,12 @@ bool CHARACTER::LearnSkillByBook(DWORD dwSkillVnum, BYTE bProb)
return false;
}
DWORD need_exp = 0;
DWORD need_exp = 20000;
if (FN_should_check_exp(this))
if ( GetExp() < need_exp )
{
need_exp = 20000;
if ( GetExp() < need_exp )
{
ChatPacket(CHAT_TYPE_INFO, LC_TEXT("You cannot read this due to your lack of experience."));
return false;
}
ChatPacket(CHAT_TYPE_INFO, LC_TEXT("You cannot read this due to your lack of experience."));
return false;
}
// bType이 0이면 처음부터 책으로 수련 가능