metin2/web
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Migrate spam_db to InnoDB and utf8mb4 #2

Merged
Exynox merged 1 commits from Tr0n/web:feat/spam-db-innodb into master 2025-01-12 16:51:17 +02:00
Conversation 1 Commits 1 Files Changed 1 +59
Tr0n commented 2025-01-01 20:29:49 +02:00
Contributor
Copy Link

How to test:

  1. Run Migration
  2. add test record to the spam_db table INSERT INTO common.spam_db (type,word,score) VALUES ('SPAM','spam',50);
  3. start/restart the game server to ensure new value is loaded
  4. send 2 whisper messages containing the word "spam" in rapid succession
  5. you should now be banned from whispering for 15 minutes.

I've tested the change using regular roman characters and with German umlauts (ö) which worked flawlessly.
No changes in client/server source necessary.
One drawback is that due to a limitation from MySQL < 5.7 the max length of spam words had to be reduced from 256 to 191 characters.

How to test: 1. Run Migration 1. add test record to the `spam_db` table `INSERT INTO common.spam_db (`type`,word,score) VALUES ('SPAM','spam',50);` 1. start/restart the game server to ensure new value is loaded 1. send 2 whisper messages containing the word "spam" in rapid succession 1. you should now be banned from whispering for 15 minutes. I've tested the change using regular roman characters and with German umlauts (ö) which worked flawlessly. No changes in client/server source necessary. One drawback is that due to a limitation from MySQL < 5.7 the max length of spam words had to be reduced from 256 to 191 characters.
Tr0n added 1 commit 2025-01-01 20:29:50 +02:00
Exynox commented 2025-01-12 16:51:05 +02:00
Owner
Copy Link

Oh, I think the 191 character limit is what made me leave that on MyISAM! That should explain it. At any rate, I tested this and it works flawlessly.

Oh, I think the 191 character limit is what made me leave that on MyISAM! That should explain it. At any rate, I tested this and it works flawlessly.
Exynox merged commit 12e8012107 into master 2025-01-12 16:51:17 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: metin2/web#2
No description provided.
Delete Branch "Tr0n/web:feat/spam-db-innodb"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?