metin2/server
metin2/server
2
2
Fork 10
Code Issues 12 Pull Requests 3 Packages Projects Releases Wiki Activity

WIP: Rename identifiers containing Korean words in source code #33

Draft
haydukk11 wants to merge 6 commits from haydukk11/server:no-korean-names into master
pull from: haydukk11/server:no-korean-names
merge into: metin2:master
Conversation 1 Commits 6 Files Changed 15 +267 -267
haydukk11 commented 2024-11-10 20:58:10 +02:00
First-time contributor
Copy Link

Hi @Exynox, I found this initially, are there any other large chunks of code using Korean names beside these ones?

Hi @Exynox, I found this initially, are there any other large chunks of code using Korean names beside these ones?
haydukk11 added 6 commits 2024-11-10 20:58:11 +02:00
Exynox commented 2024-11-16 18:18:15 +02:00
Owner
Copy Link

Hi! Looks good for now, but the same changes should also be done in the Client

Hi! Looks good for now, but the same changes should also be done in the Client
This pull request has changes conflicting with the target branch.
  • src/game/src/affect.h
  • src/game/src/char.h
  • src/game/src/char_affect.cpp
  • src/game/src/char_battle.cpp
  • src/game/src/char_item.cpp
  • src/game/src/char_skill.cpp
  • src/game/src/skill.h
  • src/game/src/trigger.cpp
View command line instructions.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u no-korean-names:haydukk11-no-korean-names
git checkout haydukk11-no-korean-names
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug

Something is not working

  
duplicate

This issue or pull request already exists

  
enhancement

New feature

  
help wanted

Need some help

  
invalid

Something is wrong

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
bug
duplicate
enhancement
help wanted
invalid
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: metin2/server#33
No description provided.
Delete Branch "haydukk11/server:no-korean-names"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?