I think the spam-related stuff should have remained?
I think we should better keep these init functions, so as for example locale_string_de.txt is loaded when German is specified, locale_string_fr.txt for French, and so on and so forth...
I don't get what happened here and what warrants the change from s_line to string?
I would have kept this variable and used it for English, so as in locale_find() to skip checking the locale string map.
Interesting, I wonder if these "7/8" skills were these beta ones: https://metin2.dev/topic/20822-ymir-beta-skills/
I see you've removed these warnings as well. I guess they aren't of much use after all.
I think there's an issue here, it looks like d->Packet(&packFailure, sizeof(packFailure)); should have remained, including the return statement and everything else. Only after the closing bracket would const TAccountTable & c_rAccountTable = d->GetAccountTable(); follow.
Shouldn't this have been kept?? g_iUseLocale is true for Europe.
I'll refactor this sometime in the future, in order to provide a secure authentication mechanism to the CMS I'm working on.
Function always returns true, therefore it can be removed.
I see, these were the 6/7 bonuses being banned here.
b1 could be renamed to bi, I suppose, therefore removing this pointer?
I see, in the YMIR locale you could only open private shops in map1/2. This reminds me of the current behaviour on present day Gameforge servers, where you can only open shops in the Bazaar.
So I suppose some players in Germany could've had extra damage as a premium feature? How broken and P2W!
Isn't percent always set to 9 here? I suppose we could just remove the if and leave percent = 9;
How weird that these two branches of the "if" were exactly the same!